Skip to content

Keep microphone mute state visible - #509

Merged
jserv merged 1 commit into
sysprog21:mainfrom
KyleLin0501:improve-muted-microphone-reminder
Oct 28, 2026
Merged

jserv merged 1 commit into
sysprog21:mainfrom
KyleLin0501:improve-muted-microphone-reminder

Conversation

@KyleLin0501

Copy link
Copy Markdown
Contributor

The interviewer's Listening, Thinking and Speaking states describe Jim's activity, not whether the candidate's microphone is muted. Candidates can therefore overlook that their audio is not being sent.

Show a persistent Mic muted indicator beside the interviewer status and strengthen the microphone button's muted text, icon and styling, with accessible names that do not rely on color. Preserve the existing interviewer states. Update the displayed mute state only after the operation succeeds; a failed unmute retains the last confirmed muted state.

Validation

42 logic and DOM-contract checks passed, along with the formatting check.

This change overlaps with #426's mute handling. Integration needs to preserve its synchronization of the mute state with a pending replacement track.

Screenshot

The interviewer still shows Listening, with Mic muted beside it and Muted on the microphone button.

截圖 2026-10-26 下午5 07 48

Close #483

Comment thread web/interview.js Resolved
Comment thread web/interview.js Resolved

@jserv jserv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase the current branch onto the upstream default branch and resolve any conflicts. Run /codetrial-review in AI agents (use $codetrial-review in Codex) and resolve all identified issues. Rework the series into minimal, logically coherent commits, squash closely related commits, and ensure all commit messages follow the project’s rules.

jserv
jserv previously requested changes Oct 26, 2026

@jserv jserv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase onto latest main branch and resolve conflicts.

@jserv jserv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase the current branch onto the upstream default branch and resolve any conflicts. Run /codetrial-review in AI agents (use $codetrial-review in Codex) and resolve all identified issues. Rework the series into minimal, logically coherent commits, squash closely related commits, and ensure all commit messages follow the project’s rules.

Candidates can overlook a muted microphone because the interviewer
status describes Jim's activity rather than microphone state.

Show the confirmed mute state beside the interviewer status and on
the microphone button, with clear text and accessible names.

Allow muting ended tracks and reflect successful operations that
finish while the interview is ending. Preserve pending input-switch
synchronization and add regression coverage.

Close sysprog21#483
@KyleLin0501
KyleLin0501 force-pushed the improve-muted-microphone-reminder branch from fedae11 to 36e8bec Compare October 28, 2026 08:42
@jserv
jserv dismissed their stale review October 28, 2026 08:55

No merge conflicts at the current head.

@jserv
jserv merged commit 86fea51 into sysprog21:main Oct 28, 2026
13 checks passed
@jserv

jserv commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Thank @KyleLin0501 for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the microphone mute state more prominent and add a speaking-while-muted reminder

2 participants