Repository navigation
Conversation
The one-screen lobby test failed on CI at 805px against an 800px viewport. Trim the credits spacing in the laptop media query to leave headroom. Harden the test so a later change fails here rather than on CI: measure the system font, Arial and a taller-metrics face, select a very long problem title, and also assert no sideways scroll and that the Start button and credits stay on screen. A failure now prints the measured layout.
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one-screen lobby test failed on CI at 805px against an 800px viewport (seen on #374). Trim the credits margin and padding in the laptop media query to leave headroom, and harden the test: it now measures the system font, Arial and a taller-metrics face with a long problem title selected, and also asserts no sideways scroll and that Start and the credits stay on screen. A failure prints the measured layout.
Verified with
node --test tests/browser/lobby.test.js(221 pass, macOS) andprettier --check; reviewed with Codex and Claude, no open findings. Not run on Linux fonts locally, so the CI browser-tests lane is the real check. Left out: a flex-footer layout, which would fix the root cause but changes the layout.