Repository navigation
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 2 files
You’re at about 98% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply to a comment to ask cubic a question or push back. It learns from your replies.
View guided diff | Re-trigger cubic
ColtenOuO
reviewed
Oct 23, 2026
ColtenOuO
requested changes
Oct 23, 2026
ColtenOuO
left a comment
Collaborator
There was a problem hiding this comment.
Please squash your commit.
Support toggling off a manually selected problem card by clicking it again. Clicking the active card clears manualProblem and keptDraw, and re-triggers recommend() if history is ready (or setProblem(null) and clears recommendation note if not) to restore the default recommendation state. Closes sysprog21#392
woohsin
force-pushed
the
deselect-problem-card-392
branch
from
October 23, 2026 20:15
5d21671 to
d798e17
Compare
Author
|
Squashed into a single commit. Thanks for the guidance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support deselecting an active problem card by clicking it again in the lobby problem picker.
When the currently chosen card is clicked:
manualProblem = falseandkeptDraw = null.recommend()if history is ready to fall back to the default recommendation engine, orsetProblem(null)if it is not.searchVisibilityExceptionstate when selecting/reselecting.Verification
Added browser test in
tests/browser/lobby.test.jsto verify:snap.card === cardId, prompt updated).manualProblem = false,keptDraw = null) and re-triggersrecommend(), clearing the manual selection prompt.Closes #392
Summary by cubic
Clicking the currently chosen problem card in the lobby picker now releases the manual selection and restores the default recommendation.
manualProblemandkeptDraw, then re-triggersrecommend()when history is ready, or clears the problem and its recommendation text otherwise.searchVisibilityExceptionstate when reselecting.Closes #392.
Written for commit d798e17. Summary will update on new commits.