Repository navigation
Allow downloading multiple selected interview reports - #453
Merged
Merged
Conversation
jserv
reviewed
Oct 23, 2026
jserv
reviewed
Oct 23, 2026
jserv
reviewed
Oct 23, 2026
yucheng922003
force-pushed
the
feat/batch-report-download
branch
from
October 23, 2026 13:35
f79990f to
6cde114
Compare
jserv
reviewed
Oct 23, 2026
jserv
reviewed
Oct 23, 2026
yucheng922003
force-pushed
the
feat/batch-report-download
branch
from
October 23, 2026 16:20
6cde114 to
f056d58
Compare
jserv
reviewed
Oct 24, 2026
yucheng922003
force-pushed
the
feat/batch-report-download
branch
from
October 24, 2026 16:28
f056d58 to
e214511
Compare
jserv
reviewed
Oct 24, 2026
| }); | ||
| nodes.attemptDownloadSelected.addEventListener("click", () => { | ||
| const selected = selectedAttempts(); | ||
| for (const attempt of selected) downloadSavedReport(attempt); |
Contributor
There was a problem hiding this comment.
Every row starts ticked, and device history keeps up to 500 reports (REVIEW_HISTORY_CAP). So a single click on Download selected with no filter runs downloadSavedReport for every report in the history, in one synchronous loop. After Chrome's one-time "multiple downloads" prompt, that can drop hundreds of .md files into the Downloads folder. Either start rows unticked, or confirm above a small count (for example window.confirm naming the number of files). For more than a few reports, a follow-up could bundle them into one archive rather than sending one download per report.
jserv
requested changes
Oct 25, 2026
jserv
left a comment
Contributor
There was a problem hiding this comment.
Rebase latest main branch and resolve conflicts.
Let candidates save multiple attempts without repetitive downloads.
yucheng922003
force-pushed
the
feat/batch-report-download
branch
from
October 25, 2026 03:46
e214511 to
ab1c28d
Compare
Contributor
|
Thank @yucheng922003 for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let candidates save multiple attempts without repe
Summary
Screenshots
Before
After — default state
After — after clicking batch download
After — filtered with no matching reports
Testing
Closes #444titive downloads.
Summary by cubic
Adds checkboxes to past interview attempts so you can download multiple saved reports at once instead of one by one.
Closes #444.
Written for commit f056d58. Summary will update on new commits.