Repository navigation
Give expanded problem cards room below setup - #410
Conversation
|
Also addressed the three AI review findings in 983d6b6: added a ResizeObserver fallback, restored compact laptop spacing, and restored the mobile select font size to 16px. |
|
Rebase latest |
983d6b6 to
7eccacf
Compare
|
Rebased onto main at 3198a99 and resolved the test conflict, preserving both sets of tests. Ran ./scripts/test.sh: all 1,367 browser tests passed; skipped checks were reviewed. |
jserv
left a comment
There was a problem hiding this comment.
Rebase the current branch onto the upstream default branch and rework the series into functionally minimal commits, folding similar ones and enforcing the project's commit message rules.
d0e0704 to
a7008eb
Compare
|
Rebased onto the latest upstream main and folded the four commits into one functional commit, a7008eb. The final file contents are unchanged, and the commit message passes the project hook. |
a7008eb to
7088b33
Compare
|
Addressed the four review comments in 7088b33: added meaningful breakpoint assertions, removed the incomplete ResizeObserver fallback, restored findability of collapsed cards with automatic expansion, and corrected the compact-spacing breakpoint to 640px. Folded the fixes into the existing commit. Ran ./scripts/test.sh: all 1,370 browser tests passed; skipped checks were reviewed. |
Confining the problem bank to Step 1 leaves wide layouts underused. Keep its controls in Step 1 and wrap fixed-width cards below the panels, retaining reading order and the narrow-screen flow. A measured outline preserves the visual connection across layouts.
7088b33 to
3a5dad1
Compare
|
Thank @hszzt for contributing! |
Since #401 each card sits in an entry that filtering hides along with it, but #410's layout test toggled only the card and counted cards by their attribute, so cards inside hidden entries measured as one row of 57. The test now hides and restores whole entries and counts what is rendered, and the outline measures the entries the grid lays out.
Problem
On wide screens, the expanded problem list is constrained to Step 1, creating a long single-column list while space below the other panels remains unused.
Implementation
Keep the picker controls in Step 1 and display fixed-width problem cards below the setup panels. Cards wrap as space changes and return inside Step 1 on narrow screens.
An L-shaped container visually connects the controls and cards. The reading and keyboard navigation order is Step 1 controls, problem cards, Step 2, then Step 3. Filtering, selection, source-title visibility, and collapse behavior are preserved.
Design for review
This differs from the proposed approach of moving the entire
details.problem-pickerbelow the setup panels. This PR presents the alternative layout for review.Screenshots
Collapsed
The problem picker is collapsed inside Step 1.

Expanded — wide window
Four fixed-width cards per row, with an L-shaped container connecting Step 1 to the cards below the setup panels.
Expanded — medium-width window
Cards wrap into three columns as the window narrows.
Expanded — narrow window
Cards return inside Step 1 and fit two per row at this width.
Validation
Ran
./scripts/test.shafter the review fixes. All 1,316 browser tests passed. The run skipped checks requiring unavailable tools and one Linux-specific Python test; these skips were reviewed.Closes #394
Summary by cubic
The expanded problem picker now uses the space below the setup panels instead of confining problem cards to a long single column in Step 1. Picker controls stay in Step 1 while fixed-width problem cards wrap below the setup panels on wide screens and return inside the picker on narrow ones; the cards stay in the DOM so reading order, focus, and screen-reader behavior are unchanged.
hidden="until-found"and fragment links reveal them by opening the picker.Written for commit 3a5dad1. Summary will update on new commits.