Repository navigation
Standardize header styles for test panel - #304
Conversation
15af14b to
74531f1
Compare
74531f1 to
6c8f672
Compare
6c8f672 to
2d0e68e
Compare
629262e to
8873c98
Compare
jserv
left a comment
There was a problem hiding this comment.
Improve git commit messages per https://cbea.ms/git-commit/ :
- Separate subject from body with a blank line
- Limit the subject line to 50 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line
- Wrap the body at 72 characters
- Use the body to explain what and why vs. how
The English writing must be improved, addressing comprehensive why vs. how.
544a798 to
58e0689
Compare
Refined the git commit message to improve the English phrasing and comprehensively explain the underlying rationale (why), thank you! |
5fca2fa to
e671c44
Compare
e671c44 to
4c9233a
Compare
4c9233a to
92dac5e
Compare
|
CI fails on the |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
1a5edde to
694bd74
Compare
694bd74 to
d1580c3
Compare
|
The screenshots should be placed in the descriptions of pull request instead of comments. |
jserv
left a comment
There was a problem hiding this comment.
Check CONTRIBUTING.md carefully and run make indent.
jserv
left a comment
There was a problem hiding this comment.
Before asking someone to review, you MUST resolve any regressions flagged by GitHub Actions.
| font-family: inherit; | ||
| font-size: 0.875rem; |
There was a problem hiding this comment.
Folding #results-toggle into this shared rule dropped its cursor: pointer, and only #candidate-case > summary sets it again, so the Test results header now shows the default arrow cursor while Add a case shows a hand. Put the cursor in the shared rule so both headers behave the same.
| font-family: inherit; | |
| font-size: 0.875rem; | |
| font-family: inherit; | |
| font-size: 0.875rem; | |
| cursor: pointer; |
| /* Drawn rather than typed, and turned by the state the button announces: | ||
| down while the results are open, up to say they can be opened. */ | ||
| #results-chevron { | ||
| display: inline-block; |
There was a problem hiding this comment.
The two arrows still disagree when closed: .drawer-chevron turns to rotate(-45deg) and points right, while #results-toggle[aria-expanded="false"] turns this one to point up. This one also keeps margin-right: 0.25rem on top of the new gap, so the "Test results" label starts further right than "Add a case". Pick one closed direction and draw both spans from one shared rule (size, spacing and transforms), keyed off [open] and aria-expanded, and update the comment above to match.
jserv
left a comment
There was a problem hiding this comment.
Rebase onto the latest main branch, fix any regressions detected by GitHub Actions, and address the review comments.
d1580c3 to
7b06e3c
Compare
jserv
left a comment
There was a problem hiding this comment.
Rebase the current branch onto the upstream default branch and resolve any conflicts. Run /codetrial-review in AI agents (use $codetrial-review in Codex) and resolve all identified issues. Rework the series into minimal, logically coherent commits, squash closely related commits, and ensure all commit messages follow the project’s rules.
7b06e3c to
2e088f7
Compare
The test panel drawer headers display inconsistent typography and toggle indicators between the case creation form and test execution status. This change aligns font properties and stateful indicator styles across both sections to establish visual continuity in the interview view. Add a browser test under tests/browser/ to verify that both headers share the same marker and typography styles, and that each marker rotates when its section opens.
2e088f7 to
3dd6b0d
Compare
|
Thank @kumi222 for contributing! |


Align section header font properties and toggle indicators across both the Add a case and Test results drawers for visual consistency.
Closes #298
Summary by cubic
Standardizes header typography and toggle indicators across the Add a case and Test results drawers so both panels look and behave consistently. Closes #298.
<details>marker above Add a case with a shared CSS-drawn chevron that rotates 90° when opened and returns when closed.Written for commit 3dd6b0d. Summary will update on new commits.