Skip to content

Standardize header styles for test panel - #304

Merged
jserv merged 1 commit into
sysprog21:mainfrom
kumi222:fix-test-panel-headers
Oct 28, 2026
Merged

jserv merged 1 commit into
sysprog21:mainfrom
kumi222:fix-test-panel-headers

Conversation

@kumi222

@kumi222 kumi222 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Align section header font properties and toggle indicators across both the Add a case and Test results drawers for visual consistency.

Closes #298


Summary by cubic

Standardizes header typography and toggle indicators across the Add a case and Test results drawers so both panels look and behave consistently. Closes #298.

  • Replaces the native <details> marker above Add a case with a shared CSS-drawn chevron that rotates 90° when opened and returns when closed.
  • Hides the native marker and applies the same font, padding, alignment, and spacing to both headers.
  • Adds a browser test verifying both headers share marker and typography styles and that each chevron rotates on open and restores on close.

Written for commit 3dd6b0d. Summary will update on new commits.

View guided diff

螢幕擷取畫面 2026-10-24 023650 螢幕擷取畫面 2026-10-24 023701

cubic-dev-ai[bot]

This comment was marked as resolved.

Comment thread web/interview.html Resolved
Comment thread web/styles.css Resolved
Comment thread web/styles.css Resolved
@kumi222
kumi222 force-pushed the fix-test-panel-headers branch from 15af14b to 74531f1 Compare October 14, 2026 09:22
jserv

This comment was marked as outdated.

@kumi222
kumi222 force-pushed the fix-test-panel-headers branch from 74531f1 to 6c8f672 Compare October 14, 2026 09:32
@kumi222
kumi222 requested a review from jserv October 14, 2026 09:37
jserv

This comment was marked as outdated.

@kumi222
kumi222 force-pushed the fix-test-panel-headers branch from 6c8f672 to 2d0e68e Compare October 14, 2026 09:43
jserv

This comment was marked as outdated.

@kumi222
kumi222 force-pushed the fix-test-panel-headers branch 2 times, most recently from 629262e to 8873c98 Compare October 14, 2026 09:56

@jserv jserv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kumi222
kumi222 force-pushed the fix-test-panel-headers branch 2 times, most recently from 544a798 to 58e0689 Compare October 14, 2026 10:11
@kumi222

kumi222 commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

Improve git commit messages per https://cbea.ms/git-commit/ :

  1. Separate subject from body with a blank line
  2. Limit the subject line to 50 characters
  3. Capitalize the subject line
  4. Do not end the subject line with a period
  5. Use the imperative mood in the subject line
  6. Wrap the body at 72 characters
  7. Use the body to explain what and why vs. how

The English writing must be improved, addressing comprehensive why vs. how.

Refined the git commit message to improve the English phrasing and comprehensively explain the underlying rationale (why), thank you!

@kumi222
kumi222 requested a review from jserv October 14, 2026 10:16
@jserv
jserv requested review from ColtenOuO and alanhc October 14, 2026 10:17
@kumi222
kumi222 force-pushed the fix-test-panel-headers branch 2 times, most recently from 5fca2fa to e671c44 Compare October 14, 2026 11:09
cubic-dev-ai[bot]

This comment was marked as resolved.

@sysprog21 sysprog21 deleted a comment from kumi222 Oct 14, 2026
@sysprog21 sysprog21 deleted a comment from cubic-dev-ai Bot Oct 14, 2026
@kumi222
kumi222 force-pushed the fix-test-panel-headers branch from e671c44 to 4c9233a Compare October 14, 2026 13:26
cubic-dev-ai[bot]

This comment was marked as resolved.

@kumi222
kumi222 force-pushed the fix-test-panel-headers branch from 4c9233a to 92dac5e Compare October 14, 2026 14:01
@jserv

jserv commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

CI fails on the indent gate: interview.html has formatting drift. Run make indent, then amend and force-push. The cargo-audit failure on the same run comes from rustls on main, not from this branch, and needs nothing from you.

jserv

This comment was marked as outdated.

@jserv

This comment has been minimized.

1 similar comment
@jserv

This comment has been minimized.

jserv

This comment was marked as outdated.

Comment thread web/styles.css Resolved
Comment thread web/styles.css Resolved
@kumi222
kumi222 force-pushed the fix-test-panel-headers branch from 1a5edde to 694bd74 Compare October 23, 2026 18:42
@kumi222

kumi222 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author
螢幕擷取畫面 2026-10-24 023650 螢幕擷取畫面 2026-10-24 023701

@kumi222
kumi222 force-pushed the fix-test-panel-headers branch from 694bd74 to d1580c3 Compare October 23, 2026 18:57
@jserv

jserv commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

The screenshots should be placed in the descriptions of pull request instead of comments.

@jserv jserv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check CONTRIBUTING.md carefully and run make indent.

@jserv jserv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before asking someone to review, you MUST resolve any regressions flagged by GitHub Actions.

Comment thread web/styles.css Resolved
Comment thread web/styles.css
Comment on lines +1877 to +1878
font-family: inherit;
font-size: 0.875rem;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folding #results-toggle into this shared rule dropped its cursor: pointer, and only #candidate-case > summary sets it again, so the Test results header now shows the default arrow cursor while Add a case shows a hand. Put the cursor in the shared rule so both headers behave the same.

Suggested change
font-family: inherit;
font-size: 0.875rem;
font-family: inherit;
font-size: 0.875rem;
cursor: pointer;

Comment thread web/styles.css
/* Drawn rather than typed, and turned by the state the button announces:
down while the results are open, up to say they can be opened. */
#results-chevron {
display: inline-block;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two arrows still disagree when closed: .drawer-chevron turns to rotate(-45deg) and points right, while #results-toggle[aria-expanded="false"] turns this one to point up. This one also keeps margin-right: 0.25rem on top of the new gap, so the "Test results" label starts further right than "Add a case". Pick one closed direction and draw both spans from one shared rule (size, spacing and transforms), keyed off [open] and aria-expanded, and update the comment above to match.

Comment thread web/interview.html Resolved
Comment thread web/styles.css Resolved

@jserv jserv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase onto the latest main branch, fix any regressions detected by GitHub Actions, and address the review comments.

Comment thread web/styles.css Resolved
Comment thread web/interview.html Resolved
@jserv
jserv dismissed their stale review October 26, 2026 03:55

No merge conflicts at the current head.

@kumi222
kumi222 force-pushed the fix-test-panel-headers branch from d1580c3 to 7b06e3c Compare October 26, 2026 17:21
Comment thread web/styles.css Resolved
Comment thread web/styles.css Resolved

@jserv jserv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase the current branch onto the upstream default branch and resolve any conflicts. Run /codetrial-review in AI agents (use $codetrial-review in Codex) and resolve all identified issues. Rework the series into minimal, logically coherent commits, squash closely related commits, and ensure all commit messages follow the project’s rules.

@kumi222
kumi222 force-pushed the fix-test-panel-headers branch from 7b06e3c to 2e088f7 Compare October 27, 2026 08:41
The test panel drawer headers display inconsistent typography and
toggle indicators between the case creation form and test execution
status. This change aligns font properties and stateful indicator
styles across both sections to establish visual continuity in the
interview view.

Add a browser test under tests/browser/ to verify that both headers
share the same marker and typography styles, and that each marker
rotates when its section opens.
@kumi222
kumi222 force-pushed the fix-test-panel-headers branch from 2e088f7 to 3dd6b0d Compare October 28, 2026 16:57
@jserv
jserv merged commit 7a804a9 into sysprog21:main Oct 28, 2026
13 checks passed
@jserv

jserv commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Thank @kumi222 for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize section header and toggle indicator styles for test panel

3 participants