Fix ServiceAccount/ClusterRole name in uninstall template#127
Open
JonnyHaystack wants to merge 1 commit intosyseleven:masterfrom
Open
Fix ServiceAccount/ClusterRole name in uninstall template#127JonnyHaystack wants to merge 1 commit intosyseleven:masterfrom
JonnyHaystack wants to merge 1 commit intosyseleven:masterfrom
Conversation
A colon is not a valid character to use in Kubernetes resource names, so this commit replaces the colon with a hyphen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A colon is not a valid character to use in Kubernetes resource names, so this PR replaces the colon with a hyphen.
Fixes #95, which was supposed to be fixed by #117
I've tagged and published the Helm chart in my fork to test it, and confirmed this fixes the issue for me: https://jonnyhaystack.github.io/designate-certmanager-webhook/
By the way, it seems that the README is outdated in stating that there is no Helm chart registry, as the GHCR OCI registry was in use for quite some time, and the GitHub Pages registry also exists. I'd be happy to make another PR to update those docs.