Skip to content

chore(deps): bump gunicorn@26.0.0, linted project#124

Merged
petruki merged 1 commit into
masterfrom
staging
May 8, 2026
Merged

chore(deps): bump gunicorn@26.0.0, linted project#124
petruki merged 1 commit into
masterfrom
staging

Conversation

@petruki
Copy link
Copy Markdown
Member

@petruki petruki commented May 8, 2026

This pull request introduces several improvements and updates across the codebase, focusing on enhanced code documentation, improved error handling, dependency upgrades, and workflow adjustments. The most notable changes are the addition of docstrings for better code clarity, improved error handling in controller functions, and updates to dependencies and GitHub Actions workflows.

Code documentation and clarity:

  • Added descriptive docstrings to many functions across src/payloads/change_request.py, src/services/switcher_client.py, src/services/switcher_service.py, and src/services/switcher_store.py to improve code readability and maintainability. (F8f9b1fdL45R45, [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

Error handling improvements:

  • Modified controller functions in src/controller/change_request.py and src/controller/home.py to explicitly return error objects or None on exceptions, ensuring clearer error propagation and handling. [1] [2] [3] [4]
  • Improved base error class usage in src/errors/__init__.py by simplifying superclass initialization.

Dependency and workflow updates:

  • Updated the gunicorn package in Pipfile from version 25.3.0 to 26.0.0.
  • Upgraded sonarsource/sonarqube-scan-action from v7.0.0 to v8.0.0 in both .github/workflows/master.yml and .github/workflows/sonar.yml. [1] [2]

VSCode and linting configuration:

  • Enhanced .vscode/settings.json with additional pylint rules, default environment manager, and whitespace trimming to enforce consistent code style and development environment.

Utility and controller function refinements:

  • Improved utility functions in src/utils/slack_payload_util.py for more robust value extraction and error prevention, including returning None when appropriate and adding docstrings. [1] [2] [3]
  • Refactored event handler signatures in src/events/request_change.py to match updated controller interfaces. [1] [2]
  • Minor controller and import cleanups in src/controller/slack_app.py, including improved OAuth flow handling and docstrings. [1] [2] [3]

These changes collectively enhance code maintainability, reliability, and developer experience.

@petruki petruki self-assigned this May 8, 2026
@petruki petruki added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels May 8, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

@petruki petruki merged commit de873ce into master May 8, 2026
5 checks passed
@petruki petruki deleted the staging branch May 8, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant