Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request refactors how remote request timeouts are configured and simplifies the remote evaluation logic for switchers. It consolidates multiple timeout settings into a single
Timeoutfield, improves the handling of value checks, and adds comprehensive test coverage for the updated behaviors. Several redundant or error-prone code paths and tests are removed, resulting in a cleaner and more robust implementation.Remote Timeout Configuration:
ReadTimeout,WriteTimeout, andPoolTimeoutinto a singleTimeoutfield inRemoteOptions, updating all usages and documentation accordingly.Timeoutfield directly, removing therequestTimeouthelper and related logic.Switcher Value Check Logic:
CheckValueto always overwrite previous value entries, ensuring only the latest value check is used in remote evaluation.IsOnandIsOnWithDetailsto share a commonsubmitmethod, clarifying the distinction between detailed and non-detailed requests.Testing Improvements and Coverage:
Codebase Simplification:
appendFilteredEntriesandrequestTimeout.Documentation Updates:
README.mdto reflect the new timeout configuration and clarify the meaning of the consolidatedTimeoutfield.These changes make the remote evaluation logic more predictable and maintainable, while also improving test coverage and documentation.