Add support for LLDB's updated qWasmGlobal packet - #420
Merged
kateinoigakukun merged 1 commit intoAug 27, 2026
Conversation
Currently the qWasmGlobal takes a frame index, making it impossible to request a global for a module instance that's not active on the stack. See #llvm-project/212833 for more details. LLDB now supports instance owning a global with an `instance:<id>` field, negotiated through `qWasmGlobalInstance+`. This PR adds support for the new variant of the packet. The legacy frame variant stays supported for (older) debuggers that do not support it. Also derive the executable code offset from the address tag bits, so the instance id matches. Assisted-by: Claude
Member
Author
MaxDesiatov
approved these changes
Aug 26, 2026
MaxDesiatov
left a comment
MaxDesiatov
left a comment
Member
There was a problem hiding this comment.
This makes sense, thank you!
kateinoigakukun
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the qWasmGlobal takes a frame index, making it impossible to request a global for a module instance that's not active on the stack. See #llvm-project/212833 for more details.
LLDB now supports instance owning a global with an
instance:<id>field, negotiated throughqWasmGlobalInstance+. This PR adds support for the new variant of the packet. The legacy frame variant stays supported for (older) debuggers that do not support it.Also derive the executable code offset from the address tag bits, so the instance id matches.
Assisted-by: Claude