Remove ImportError and restrict ResourceLimiter to class types - #393
Merged
Conversation
Import-resolution and module-registration failures are ordinary instantiation errors, so report them as WasmKitError messages instead of maintaining a separate error type and a per-call-site wrapper.
Embedded Swift supports only class-bound existentials, so constrain the protocol to AnyObject to keep using `any ResourceLimiter` on every platform instead of introducing generic parameters or per-config storage.
kateinoigakukun
force-pushed
the
katei/instantiation-prep
branch
from
July 29, 2026 12:32
54ad7a1 to
01a5bb0
Compare
kateinoigakukun
changed the title
kateinoigakukun
added this pull request to the merge queue
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the incremental upstreaming of Embedded Swift support (#357). Follows #391.
Two preparatory changes for the instantiation path:
ImportErrorin favor ofWasmKitErrormessages. Import-resolution and module-registration failures are ordinary instantiation errors, so they are reported asWasmKitErrormessages instead of maintaining a separate error type. Error messages are unchanged.ResourceLimiterto class types. Embedded Swift supports only class-bound existentials, so the protocol is constrained toAnyObject. This keepsany ResourceLimiterusable on every platform with no generic parameters or per-configuration storage.DefaultResourceLimiterand the fuzzer's limiter become final classes.