Add MultiThread trait and PlatformMutex wrapper - #390
Merged
Conversation
kateinoigakukun
force-pushed
the
katei/multithread-trait
branch
from
July 27, 2026 07:17
5fbcbe0 to
f205064
Compare
PlatformMutex is Synchronization.Mutex when the (default-on) MultiThread trait is enabled and plain unsynchronized storage when disabled for single-threaded environments; Interner adopts it.
kateinoigakukun
force-pushed
the
katei/multithread-trait
branch
from
July 27, 2026 07:41
f205064 to
7d559c0
Compare
kateinoigakukun
added this pull request to the merge queue
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Embedded Swift support work (#357), split out for incremental review.
Adds a
MultiThreadpackage trait (enabled by default) and aPlatformMutexwrapper inSources/WasmKit/Platform/:PlatformMutexis backed bySynchronization.Mutex, forwarding the closure directly so the state type needs noSendablebound.Synchronizationmodule provides noMutex. Disabling the trait is a promise that the process runs single-threaded, so the fallback carries@unchecked Sendable.Interneradopts the wrapper, replacing its directMutexuse. Its lock property is annotatednonisolated(unsafe)because the single-threaded fallback mutates in place (mutating withLock), whichSendablechecking cannot see through. The class conformance itself stays checked.The CMake build defines
MultiThreadunconditionally. No functional change with default traits.