Skip to content

[6.4.x] Enable Android emulator testing with the 6.4 snapshot toolchain employing swift-build in SwiftPM - #1796

Merged
stmontgomery merged 1 commit into
swiftlang:release/6.4.xfrom
finagolfin:droid
Aug 25, 2026
Merged

stmontgomery merged 1 commit into
swiftlang:release/6.4.xfrom
finagolfin:droid

Conversation

@finagolfin

@finagolfin finagolfin commented Jul 15, 2026 •

Copy link
Copy Markdown
Member

@finagolfin

Copy link
Copy Markdown
Member Author

@grynspan, these nightly-main workflows fail on all 6.4 pulls, can remove those non-Android ones too if you'd like.

@finagolfin

Copy link
Copy Markdown
Member Author

@stmontgomery, anything holding up getting this in? The three failing nightly-main workflows on this pull are failing on all 6.4 pulls, eg this last one, so I can just remove those as part of this pull, if wanted.

This will give better test coverage for the 6.4 branch.

@finagolfin

Copy link
Copy Markdown
Member Author

Rebased on latest 6.4 branch

@finagolfin

Copy link
Copy Markdown
Member Author

Simply rebased again, @harlanhaskins, could you take a look?

@finagolfin

Copy link
Copy Markdown
Member Author

Rebased and updated workflows to latest tag.

@jerryjrchen, could you review? The others I pinged don't seem to be too active here lately, may be busy with other stuff.

@stmontgomery stmontgomery added this to the Swift 6.5.0 (main) milestone Aug 25, 2026
@stmontgomery stmontgomery added build 🧱 Affects the project's build configuration or process android 🤖 Android support labels Aug 25, 2026
@stmontgomery

Copy link
Copy Markdown
Contributor

@finagolfin I'm OK with taking this, but since this is targeting the release/6.4.x branch can you fill out the PR template?

Also note that 6.4.1 just recently branched, so consider whether you want to include this change in the release/6.4.1 branch as well, and post a separate PR for that if so. I think it's too late to consider this for the release/6.4.0 branch.

@finagolfin

Copy link
Copy Markdown
Member Author

since this is targeting the release/6.4.x branch can you fill out the PR template?

Sure, I thought it's not needed since these are only minor CI changes, not code changes, but can add that info here if you prefer.

consider whether you want to include this change in the release/6.4.1 branch as well, and post a separate PR for that if so.

Saw that, will do.

I think it's too late to consider this for the release/6.4.0 branch.

Don't much care, as this is a pure CI pull, which only adds a bit more testing and keeps the swiftlang workflows up to date.

That just depends on your CI policy: some want the latest workflows for all tested branches on their repos, others may not.

Given that almost everything is passing on this latest CI run- with the one linux failure using the Swift 6.5 toolchain failing on other 6.4 pulls also, ie unrelated to this CI pull- I think it is better to use the latest swiftlang workflows for 6.4.0 too, but up to you.

@grynspan grynspan changed the title Enable Android emulator testing with the 6.4 snapshot toolchain employing swift-build in SwiftPM (#1745) [6.4.x] Enable Android emulator testing with the 6.4 snapshot toolchain employing swift-build in SwiftPM Aug 25, 2026
@grynspan

Copy link
Copy Markdown
Contributor

A 6.4.1 cherry-pick is probably not necessary as changes are going to be minimal for that release.

@finagolfin

Copy link
Copy Markdown
Member Author

Rebased and added the release branch info asked for.

@stmontgomery stmontgomery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @finagolfin!

@stmontgomery
stmontgomery merged commit 2c9c2f2 into swiftlang:release/6.4.x Aug 25, 2026
26 of 27 checks passed
@finagolfin
finagolfin deleted the droid branch August 25, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

android 🤖 Android support build 🧱 Affects the project's build configuration or process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants