Repository navigation
Improved error handling in JExtract JNI mode - #928
Open
madsodgaard wants to merge 9 commits into
Open
madsodgaard wants to merge 9 commits into
madsodgaard wants to merge 9 commits into
Conversation
ktoso
reviewed
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #826
Currently, the only way to handle specific errors in the JExtract JNI mode, is to do a string "contains" against the
Exceptionmessage. This is quite flakey, and not a nice experience for Java developers.This PR makes extracted
Errortypes extendExceptionitself, which means Java developers can catch Swift errors as normal Java exceptions. For typed throws we also explicitly can state that the Java method throws a specific exception.Also introduces a
AnySwiftError, which is thrown when we cannot extract a concrete userErrortype.