Include progress checks with bounded repetition - #872
Open
natecook1000 wants to merge 1 commit into
Open
Conversation
This enables forward progress checks for all quantification kinds,
which were previously skipped for bounded quantification (i.e.
/^{,5}/) as an optimization. Even bounded quantifications can cause
runaway matching execution time when not progressing through the
input, particularly if nested.
rdar://185731142
Member
Author
|
Benchmark results look like noise: https://github.com/swiftlang/swift-experimental-string-processing/actions/runs/33087702047/job/98571797598?pr=872 |
Member
Author
|
@swift-ci Please test Linux platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables forward progress checks for all quantification kinds, which were previously skipped for bounded quantification (i.e.
/^{,5}/) as an optimization. Even bounded quantifications can cause runaway matching execution time when not progressing through the input, particularly if nested.rdar://185731142