Skip to content

make HTTPClient public ~Copyable - #225

Merged
swhitty merged 1 commit into
mainfrom
HTTPClient
Jul 16, 2026
Merged

make HTTPClient public ~Copyable#225
swhitty merged 1 commit into
mainfrom
HTTPClient

Conversation

@swhitty

@swhitty swhitty commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Make the private spa _HTTPClient public, and ~Copyable allowing it stream responses closing the socket when done.

resolves #216

@swhitty
swhitty merged commit 8cdf7e4 into main Jul 16, 2026
30 of 33 checks passed
@swhitty
swhitty deleted the HTTPClient branch July 16, 2026 04:06
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.91%. Comparing base (5364faa) to head (00624f4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
- Coverage   92.91%   92.91%   -0.01%     
==========================================
  Files          71       71              
  Lines        3728     3727       -1     
==========================================
- Hits         3464     3463       -1     
  Misses        264      264              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Status of _HTTPClient?

1 participant