fix(dashboard): one line per model in the earnings breakdown - #141
Merged
Merged
Conversation
Each model row rendered 32px tall — two lines. The token column is a fixed w-28 (112px) but its own content, "1.96M in / 94.4k out" at 12px, is wider than that, so the text wrapped inside the column and doubled the height of every row. Six models therefore took twelve lines. The column is now wide enough for its content and marked whitespace-nowrap so it cannot wrap again if the numbers grow a digit, and the rows are set to 11px. Rows measure 16px each. Also drops the "Latest interval" label. It was correct when the panel defaulted to the newest bucket and became wrong when it started summarising the window — it sat next to a heading reading "24 hours", contradicting it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #140, from the same panel.
Rows were double height
Each model row measured 32px — two lines. The token column is a fixed
w-28(112px) while its content,
1.96M in / 94.4k outat 12px, is wider, so itwrapped inside its own column and doubled every row. Six models took twelve
lines.
Measured on the live dashboard, before:
after:
The column is now wide enough for its content and
whitespace-nowrap, so itcannot silently re-wrap if a figure gains a digit; rows are 11px.
Stale label
Latest intervalwas correct while the panel defaulted to the newest bucket.#140 changed the default to the whole window and left the label, so it sat
beside a heading reading
24 hoursand contradicted it. Removed.