fix: enforce Linux x86_64 platform boundary#246
Merged
Conversation
Reject unsupported build targets, installer hosts, and target ELF objects before architecture-specific tracing logic can run. Keep the SCOPE-1 contract aligned with compile-time, install-time, runtime, and regression-test enforcement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review notes
The platform-specific register, ABI, TLS, and unwind paths are x86_64-only.
Release artifacts alone did not prevent unsupported source builds or targets.
This change makes those boundaries fail closed at build, install, and runtime.
During review, the installer was also updated to reject x86_64 non-Linux
hosts, matching the documented Linux x86_64 support envelope.
Validation
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test -p ghostscope-process -p ghostscope-dwarf --libcargo test -p ghostscope --all-features7b2637cbc9a1)The first full e2e run hit a late-start/sysmon timing failure in an existing
test. Its focused rerun passed, followed by a complete successful full run.
Container-topology e2e was intentionally skipped because this change does not
affect container or PID-namespace behavior.