fix: stream promised read results lazily - #16622
Open
Nic-Polumeyv wants to merge 1 commit into
Open
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/d26ff54def3fa95bc4c670989b5a4e46210b12dbOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: d26ff54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| }); | ||
| } | ||
|
|
||
| // TODO remove the cast once TypeScript's lib includes `ReadableStream.from` |
Contributor
There was a problem hiding this comment.
wrapped_read uses ReadableStream.from() and async iteration of a ReadableStream (yield* stream), which are not supported on Cloudflare's workerd runtime, throwing at runtime when server-side asset reads occur on the Cloudflare adapter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promised
read()results held the whole file in memory instead of streaming it.ReadableStream.fromexists everywhere the server runtime ships (Node 20.6+, workerd, Deno, Vercel edge).Partial reads of a 100MB file drop from 82MB of memory to basically nothing, huge win.