Repository navigation
Raise Java baseline from 1.8 to 11 - #271
Merged
Merged
Conversation
Replace maven.compiler.source/target=1.8 with maven.compiler.release=11 on the root aggregator pom, propagating to all submodules except servlet/simple (already pinned to 19, required by Jetty 12 / Jakarta Servlet 6.1). Drop the redundant per-module 1.8 override in xml/jaxb/generate-code-from-xsd, which already depends explicitly on javax.xml.bind:jaxb-api + jaxb-runtime rather than JDK-bundled JAXB. Remove circle.yml and Jenkinsfile: circle.yml hardcoded JDK 8 and -Dmaven.compiler.source/target=1.8 flags that would conflict with the new baseline, and both are superseded by the active GitHub Actions CI (build-with-maven.yml). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xc3mSQVPd3CmhzCkx97aXP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maven.compiler.source/target=1.8withmaven.compiler.release=11on the root aggregator pom, propagating to all submodules exceptservlet/simple(already pinned to 19, required by Jetty 12 / Jakarta Servlet 6.1)xml/jaxb/generate-code-from-xsd, which already depends explicitly onjavax.xml.bind:jaxb-api+jaxb-runtimerather than JDK-bundled JAXB (removed in Java 11)circle.ymlandJenkinsfile:circle.ymlhardcoded JDK 8 and-Dmaven.compiler.source/target=1.8flags that would conflict with the new baseline, and both are superseded by the active GitHub Actions CI (build-with-maven.yml)Test plan
mvn --batch-mode --strict-checksums verify— all 8 modules build, tests passmvn checkstyle:checkstyle -Dcheckstyle.config.location=google_checks.xml -Dcheckstyle.suppressions.location=./checkstyle-suppressions.xmlmvn pmd:check pmd:cpd -DlinkXRef=falsexml/jaxb/generate-code-from-xsd's dependency tree resolvesjavax.activation-apitransitively under the new baseline🤖 Generated with Claude Code
https://claude.ai/code/session_01Xc3mSQVPd3CmhzCkx97aXP