Ensuring unit consistency in ALARAPlot - #331
Open
eitan-weinstein wants to merge 1 commit into
Open
eitan-weinstein wants to merge 1 commit into
eitan-weinstein wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a small function
get_var_unit()toalara_output_plottingthat ensures that all units for a single-variable ALARADFrame are the same. This will either raise aValueErrorif they are not, or return the singular unit type. Additionally, in its implementation, eachfiltered_adfis concatenated to an accumulated ADF used for cross-checking singular unit compliance across data from all runs in a single plot.While I have not run into any issues of mismatching units, this fix seemed to me like a valuable defensive measure.
Part of the #328 changes.