Update Sound System - #80
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 333bcd89d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,2 +1,3 @@ | |||
| all: | |||
| cd 01_degrade && make PATH=${PATH} | |||
| cd ../src/test && ./vgm_analog_test | |||
There was a problem hiding this comment.
On a clean checkout, the root Makefile's ci target enters test without first building anything in src/test, so this line attempts to execute a nonexistent ../src/test/vgm_analog_test and makes the CI target fail. I checked the repository targets: only src/test/Makefile knows how to build this binary, and no preceding CI step invokes it; add that build as a prerequisite or invoke make there before running the test.
Useful? React with 👍 / 👎.
1 participant
--ym-analog=off|clean|subtle|real|re1e|warmオプションを追加