Skip to content

implement widths for table columns and scss changes in general #10

Description

@olivermt

This requires scss work and will not work with CDN linked bulma.

Not sure what to do here.
Expose the scss stuff and let people link it in as an asset?

The scss to enable this is pretty trivial: https://gist.github.com/alalfakawma/b94de00f31895b91077a2e3f71ace1fe

But in general a lot around bulma revolves around altering variables in a scss setting, so the library should probably enable a way to utilize scss stuff from priv or asset folder, then expose that back out as something you can use in a ´link´ element.

Would appreciate feedback / oppinions @msaraiva :)

Activity

  1. self-assigned this
    on Feb 4, 2021
  2. msaraiva commented on Feb 5, 2021

    @msaraiva
    Member

    @olivermt should we care about that? I mean the user can (or maybe should) use npm/webpack (or anything similar) to have full control of the build process. The CDN solution is mostly for cases where the default settings are enough like our website or the catalogue.

    I might be missing something though :)

  3. olivermt commented on Feb 5, 2021

    @olivermt
    ContributorAuthor

    I think controlling table column widths is a must-have, just remember the gif I gave you, the columns were fluctuating in width due to the caret moving to the other column.

    For anyone coming over from bootstrap it’s going to be a huge hole if you work with tables a lot.

    Could potentially mark the prop with saying you need custom scss to make it work and include a guide in the hexdocs.

  4. msaraiva commented on Feb 5, 2021

    @msaraiva
    Member

    Does this feature depend exclusively on CSS? Can't we solve that setting the style directly? If not, could scoped CSS as discussed in surface-ui/surface#1 solve it? Sorry it this should be trivial but I'm not sure in what circumstances we can't implement that or maybe I misunderstood the feature.

  5. olivermt commented on Feb 5, 2021

    @olivermt
    ContributorAuthor

    well to be honest, this is just extra css, it doesn't change the existing css.
    so maybe we can just include another stylestheet with surface_bulma?

  6. msaraiva commented on Feb 5, 2021

    @msaraiva
    Member

    If we had surface-ui/surface#1 then yes, we could do this automatically. Otherwise, the best we can do is to instruct the user to add it himself. I hope I can find some time in the next couple of weeks to get back to work on this feature. It would be great if we could just add a colocated CSS or JS file like:

    table.ex
    table.css
    table.js
    

    and everything could work magically.

    I find the set up of external CSS & JS stuff goes totally against the concept of "self-contained components".

  7. changed the title [-]implement widths for columns and scss changes in general[/-] [+]implement widths for table columns and scss changes in general[/+] on Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions