Repository navigation
Conversation
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blst_256_t::to(const unsigned char*, size_t, bool) imports a variable-length byte string into a field element, the C++ mirror of the C blst_scalar_from_be_bytes() entry point. It sizes the leading partial digit with rem = (n - 1) % 32 + 1, but unlike the C version it never special-cases n == 0. When a caller imports an empty value the (n - 1) subtraction underflows to SIZE_MAX, rem lands on 32, and the following n -= rem drives n to SIZE_MAX - 31, so the digit loop keeps reading 32-byte chunks well past the end of the buffer. I ran into it while exercising zero-length imports and AddressSanitizer reported a stack-buffer-overflow read on the first loop iteration. The C siblings in exports.c already guard this with n ? (n - 1) % 32 + 1 : 0, so I applied the same guard here, which makes an empty input decode to the zero element and leaves every n >= 1 path unchanged.