Repository navigation
Conversation
Contributor
|
Typo in the title 😅 - blst_blst_from_{lb}e_bytes
+ blst_fp_from_{lb}e_bytes |
dot-asm
force-pushed
the
blst_fp_from_be_bytes
branch
from
October 26, 2025 12:33
10463fe to
2b9bf4b
Compare
Collaborator
Author
Thanks! |
|
This looks perfect :) I don't know if you have any testing setup, but I did check some outputs of the big endian function against manual python-assisted calculations, and at least on my system I got what I expected given the code. |
Collaborator
Author
|
I've tested big-endian variant as replacement for the inner loop in hash_to_field and then compared results to be equal for few oversize random inputs for big- and little-endian variants, naturally with reversed bytes in the inputs. |
Collaborator
Author
|
Committed. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.