Repository navigation
chore(api): remove unused in-memory recipe idempotency store - #94
Draft
tomdmeredith wants to merge 1 commit into
Draft
tomdmeredith wants to merge 1 commit into
tomdmeredith wants to merge 1 commit into
Conversation
Live recipe and capability execute already claim keys through DurableIdempotencyStore. Drop the unused in-memory store, the safety gate branch that consulted it, and the tests that only covered it. Co-authored-by: tomdmeredith <tomdmeredith@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propose-only cleanup for the 2026-10-02 nightly audit (
in-memory-idempotency). Do not merge. Do not deploy.Live recipe and capability execute already claim idempotency keys through
DurableIdempotencyStore. This removes the unused in-memory store from the recipe safety gate.IdempotencyRecordandIdempotencyStorefrompackages/api/services/recipe_safety.py.RecipeSafetyGateno longer accepts an in-memory store, andcheck_pre_execution/finalize_executionno longer consult one.get_safety_gate()still buildsRecipeSafetyGate()with no in-memory store.packages/api/services/durable_idempotency.pyand the durable claim/store wiring inrecipes_v2.pyandcapability_execute.pyunchanged.Proof
rg '\bIdempotencyStore\b'matches only the historical note indurable_idempotency.py. Recipe execute still claims and stores keys withDurableIdempotencyStoreinrecipes_v2.py.pytest tests/test_recipe_safety.py tests/test_recipes_v2.py tests/test_durable_idempotency.py— 134 passed.Out of scope
Open drafts #91, #90, and #89. OperationType / financial counters,
conversation_in_scope, canonicalizers, and Awal scripts are untouched. No secrets edited.