fix(browser-extension): make the save-memory keyboard shortcut fire - #1598
Open
Rikinshah787 wants to merge 1 commit into
Open
fix(browser-extension): make the save-memory keyboard shortcut fire#1598Rikinshah787 wants to merge 1 commit into
Rikinshah787 wants to merge 1 commit into
Conversation
The keydown handler checked event.shiftKey && event.key === "m", but with Shift held the key value is "M", so the condition could never be true and Ctrl/Cmd+Shift+M did nothing on any page. Compare the key case-insensitively instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small one: the global save shortcut in the content script checks
event.shiftKey && event.key === "m", but with Shift held the key value is uppercase "M", so the condition can never be true and Ctrl/Cmd+Shift+M does nothing on any page (about the only way to trigger it was Shift with Caps Lock on). Compare the key case-insensitively.No test - the extension has no test setup and it's a one-liner. The
!event.shiftKeychecks in the per-site content scripts (chatgpt/claude/gemini/t3) are Enter handlers and unaffected.