Skip to content

add semantically mass-forget memories endpoint to docs#1170

Open
sohamd22 wants to merge 1 commit into
06-24-docs_update_for_profile_buckets_and_inferred_memory_reviewfrom
06-28-add_semantically_mass-forget_memories_endpoint_to_docs
Open

add semantically mass-forget memories endpoint to docs#1170
sohamd22 wants to merge 1 commit into
06-24-docs_update_for_profile_buckets_and_inferred_memory_reviewfrom
06-28-add_semantically_mass-forget_memories_endpoint_to_docs

Conversation

@sohamd22

@sohamd22 sohamd22 commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Docs: add Forget Matching endpoint + fix stale Forget Memory docs

What this does

  • Adds docs for the new POST /v4/memories/forget-matching endpoint — semantic/promptable mass-forget. Covers dryRun (preview), threshold/maxForget safety bounds, the request/response shape, and forgetBatchId.
  • Corrects the existing "Forget Memory" section to match the actual implementation.

⚠️ No API surface changed

This PR is docs-only. The existing forget endpoint's behavior/contract is untouched — the previous docs were simply wrong and described a route that has never existed:

Old docs (incorrect) Actual implementation (unchanged)
Method + path POST /v4/memories/{id}/forget DELETE /v4/memories
Body { id | content, containerTag, reason? }

The handler (forgetMemory in apps/api/src/routes/v4/memories/handlers.ts) was not modified — this just makes the docs reflect reality.

Also

  • Small accuracy cleanups (response field descriptions, realistic example IDs).

@vorflux

vorflux Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Vorflux skipped this auto review because this account has reached its Auto Review daily review limit (20/20). You can change this in Auto Review Settings: https://us1.vorflux.com/supermemory/settings?section=pull-requests

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp d2eab9d Jun 27 2026, 07:28 PM

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app d2eab9d Commit Preview URL Jun 27 2026, 07:29 PM

@sohamd22 sohamd22 marked this pull request as ready for review June 27, 2026 19:32
@graphite-app graphite-app Bot requested a review from Dhravya June 27, 2026 19:32
@claude

claude Bot commented Jun 27, 2026

Copy link
Copy Markdown

Claude finished @sohamd22's task in 1m 59s —— View job


Review Complete

  • Gather context and review the diff
  • Verify documentation accuracy against actual API implementation
  • Check for any issues or inconsistencies
  • Submit review

Summary: This is a clean docs-only PR. The Forget Memory docs were corrected to match the actual SDK usage (verified in apps/mcp/src/client.ts), and the new Forget Matching endpoint is well-documented with appropriate safety warnings for the bulk operation.

Score: 10/10 — No bugs, security issues, or logic errors found.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Docs-only PR that corrects the Forget Memory endpoint documentation (from non-existent POST /v4/memories/{id}/forget to actual DELETE /v4/memories with body params) and adds documentation for the new semantic bulk-forget endpoint (POST /v4/memories/forget-matching).

Issues found: None — this looks good to ship.

I verified the corrected Forget Memory docs match the SDK usage pattern in apps/mcp/src/client.ts:179-228, where this.client.memories.forget() takes {id | content, containerTag} parameters. The new Forget Matching docs are well-structured with appropriate warnings about the destructive nature of bulk operations, dryRun support, and safety bounds (threshold, maxForget).

Score: 10/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants