UserManagementView: Determine current user via /api/user - #255
Open
FideliusFalcon wants to merge 1 commit into
Open
UserManagementView: Determine current user via /api/user#255FideliusFalcon wants to merge 1 commit into
FideliusFalcon wants to merge 1 commit into
Conversation
USER_USERNAME was removed from /api/system/config in Grocy 4.7.0, so userUsername is nil against newer servers and no row is ever treated as the current user. This disables the safeguard that prevents deleting your own account. Use the already fetched currentUser instead, matching how TasksView and ChoresView identify the current user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isCurrentUserinUserManagementViewwas derived fromUSER_USERNAMEin/api/system/config. Grocy 4.7.0 removed that key (grocy commitb6c07a51), and makinguserUsernameoptional in dc3bd72 fixed the decoding error but left the value permanentlynilagainst 4.7.0+ servers.isCurrentUseris therefore alwaysfalse, which disables the guard inUserRowActionsView:The delete button is live on your own account, and grocy's
UsersApiController::DeleteUserhas no server-side self-deletion check.This uses
grocyVM.currentUser, populated from/api/user, and compares byid— the same approachTasksViewandChoresViewalready use./api/useris present in both 4.6.0 and current grocy, so behaviour is unchanged on older servers..system_configis no longer requested by this view, and the now-unusedsystemConfigListquery is removed.Built for iOS (Xcode 26.6, iOS 26.5 simulator SDK):
BUILD SUCCEEDED. Not verified at runtime.