Shrvan Benke — PO terms conflict checker and restaurant corrective-plan app - #133
Open
01shrvan wants to merge 9 commits into
Open
Shrvan Benke — PO terms conflict checker and restaurant corrective-plan app#13301shrvan wants to merge 9 commits into
01shrvan wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shrvan Benke — both assigned builds for the SuperDocs Round 2 engineer task.
use-cases/01shrvan/po-terms-conflict-checker(S3)Compares a buyer's purchase order against a supplier's acknowledgement clause area by clause area, quotes both sides on every contested point, states which document is likely to govern given the recorded sequence of events, and drafts the objection or confirmation letter that preserves the buyer's position.
Matching is by substance rather than heading — the bundled
pile-bshares none ofpile-a's headings ("Liability Ceiling", "Forum for Disputes") and still resolves every area. Silence is reported as a finding distinct from a conflict, with its own band in the interface and its own section in the memo, because a reader who skims a conflicts list and doesn't find warranty there will conclude warranty is agreed. It isn't — nobody said anything.The "which document governs" analysis is not a model call. The sequence of events is explicit input, the doctrine lives in
rules/last-shot-england.json, and the output names the facts it relied on and carries a disclaimer. Adding one objection event before performance flips the conclusion; dating it after delivery does not. 43 tests.use-cases/01shrvan/restaurant-corrective-plan(S2)Takes cited health-inspection violations and drafts a corrective plan with a fix and a named owner per violation code, formatted for resubmission to the health department.
The centrepiece is a coverage verifier that refuses a plan where actions or owners are copied between codes, where a code was cited but not answered, or where the plan invents a code nobody cited. Hand-written fixtures include a blended single paragraph and individually-coded boilerplate; both are rejected. 21 tests.
Notes
/v1/chat/asyncwithapproval_mode: "ask_every_time"), not the synchronous/v1/chatshown in the quickstart — that endpoint applies edits immediately and returns nochange_id, so approval is impossible on it. Reported as a bug./api/exportrenders locally and produces HTML only. Asking either build fordocxreturns501naming where DOCX is available, rather than handing back HTML bytes under a.docxname.