Repository navigation
Remove the demo analytics prompt and floating settings button - #126
Merged
mattConnHarbour merged 3 commits intoNov 17, 2026
Merged
mattConnHarbour merged 3 commits into
mattConnHarbour merged 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unsolicited analytics prompt and floating Privacy settings button from the gallery and all five demos. Per the owner's explicit choice, fresh public visitors use the existing bounded analytics without a prompt. Saved declines remain respected, including older saved refusals, along with DNT, GPC and explicit opt-outs. No visitor identification, document text, prompts, filenames or private links are added to measurement.
The actual-adapter regressions cover every published route, fresh/default measurement, saved refusals, withdrawal and browser opt-outs, and reject injected visible controls. Six default-collection regressions fail before the behavior change; all 108 release-script checks pass afterward. Desktop Chromium and phone WebKit previews reproduce the old controls and verify their absence with this adapter; the analytics frame is replaced by an inert fixture and no production analytics requests are sent.
All CI checks pass on edb18ae, including app builds, unit tests, release checks, quickstarts and browser tests. Normal maintainer review, merge/release and public readback remain required. This account has upstream read-only access. No dependency manifest or lock was changed.
Companion playbook/runbook update: https://github.com/superdoc/sales-engine/pull/118. Homepage cookie UI and all unrelated product controls are unchanged.