Repository navigation
fix(ci): allow production releases after fork PR merges - #123
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fork PR merges currently start production releases through
pull_request, where GitHub withholds repository deployment settings and secrets. In release #352, validation passed, but release assembly stopped at the missing version-history backend setting and the Slack job failed without its token.Use
pull_request_targetonly for closed PRs merged intomain, retain the merged-only job guard, and recognize that trusted event in notification handling. Release checkout still selects the merged base-repository commit; unmerged fork heads are never executed. Scheduled releases and manual dry-run safeguards remain in place.Validation