Skip to content

fix(ci): allow production releases after fork PR merges - #123

Merged
mattConnHarbour merged 1 commit into
mainfrom
codex/fix-release-after-fork-merge
Nov 15, 2026
Merged

mattConnHarbour merged 1 commit into
mainfrom
codex/fix-release-after-fork-merge

Conversation

@mattConnHarbour

Copy link
Copy Markdown
Collaborator

Summary

Fork PR merges currently start production releases through pull_request, where GitHub withholds repository deployment settings and secrets. In release #352, validation passed, but release assembly stopped at the missing version-history backend setting and the Slack job failed without its token.

Use pull_request_target only for closed PRs merged into main, retain the merged-only job guard, and recognize that trusted event in notification handling. Release checkout still selects the merged base-repository commit; unmerged fork heads are never executed. Scheduled releases and manual dry-run safeguards remain in place.

Validation

  • Two new regressions failed before the fix and pass after it: trusted merged-fork notification handling and the privileged workflow's merged-only trigger/checkout contract.
  • All 69 release/repository automation tests pass locally.
  • Suppression tests cover unmerged ordinary and trusted PR events with mocked Slack delivery; no live test messages were sent.

@mattConnHarbour
mattConnHarbour merged commit 79c311c into main Nov 15, 2026
20 checks passed
@mattConnHarbour
mattConnHarbour deleted the codex/fix-release-after-fork-merge branch November 15, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant