feat(painter-dom): Register chart renderer as a feature module#3606
Open
ggdaltoso wants to merge 5 commits into
Open
feat(painter-dom): Register chart renderer as a feature module#3606ggdaltoso wants to merge 5 commits into
ggdaltoso wants to merge 5 commits into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This commit introduces a new rendering feature for various types of charts in the feature registry. The new entry includes support for bar, line, stock, area, scatter, bubble, radar, pie, doughnut, and of pie charts, along with the corresponding module and specification reference.
This module renders DrawingML chart blocks as inline SVG elements, supporting various chart types with performance guardrails in place.
Updated the import path for the chart rendering function to point to the new features directory structure.
This commit introduces smoke tests to verify that all exports are correctly re-exported through the feature barrel and that the module handles every registered chart type without throwing or returning a generic placeholder. Full rendering correctness is covered by chart-renderer.test.ts.
ggdaltoso
force-pushed
the
feat/register-chart-feature-module
branch
from
0f6d7c3 to
2bc2d2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been studying the codebase and noticed that
chart-renderer.tswas already living in its own file but wasn't registered infeature-registry.ts, unlikeinline-directionandmath, which follow the feature module pattern described inCLAUDE.md.This PR wires it up. No logic was changed; just the import path in
renderer.tsnow goes through the feature barrel, and charts are finally discoverable via the registry.(Genuinely impressed by how well-documented and thought-through the architecture is, btw. Learned a lot just reading through it!)