feat(superdoc): expose pendingSelection on the pending comments-update event (SD-3323)

[caio-pizzol]

The pending comments-update event now carries pendingSelection — the Document API selection snapshot taken before insertComment('pending') runs. A consumer building a custom comment composer previously had to track the selection continuously (stashing the latest non-empty snapshot) because by the time the pending event fired the live DOM selection was gone. Now they read it straight off the event.

ui.comments.createFromCapture's input is widened to CommentAnchorCapture (anything carrying a target), so the event's SelectionInfo forwards directly:

superdoc.on('comments-update', (e) => {
  if (e.type === 'pending' && e.pendingSelection?.target) {
    ui.comments.createFromCapture(e.pendingSelection, { text });
  }
});

The field is typed SelectionInfo, not SelectionCapture — that's what the snapshot actually is (target/text, not the controller-derived selectionTarget/quotedText). createFromCapture only reads target, so a full SelectionCapture isn't needed and we avoid duplicating the UI-controller's selectionTarget derivation in the store.

Review: the field name + SelectionInfo type (vs forcing a full SelectionCapture), and the createFromCapture input widening to CommentAnchorCapture (newly exported from super-editor/ui and superdoc/ui).
Verified: comments-store.test.js → 115 passed; comments.test.ts → 22 passed; check:public:superdoc → 13/13 stages PASS; manual dev-app smoke → pending event carries pendingSelection.target before the pending mark is inserted.

[linear-code]

SD-3323

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0821ee78a3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Gate pendingSelection to SuperEditor selections

When the comment tool is invoked from a PDF selection (activeSelection.source === 'pdf' in the shared toolbar flow), superdoc.activeEditor can still point at a DOCX editor, so this call captures that editor's stale Document API selection and emits it as pendingSelection for the PDF pending comment. Consumers following the new guidance and passing that payload to ui.comments.createFromCapture would then create/anchor a DOCX comment instead of treating the PDF comment as having no Document API text target; gate this snapshot on the active selection/source (or document id) and emit null outside SuperEditor text selections.

Useful? React with 👍 / 👎.

[cubic-dev-ai]

cubic analysis

No issues found across 8 files

Linked issue analysis

Linked issue: SD-3323: Expose the pending selection on the pending comment event

Status	Acceptance criteria	Notes
✅	Emit the 'comments-update' pending event with a pendingSelection payload (Document API SelectionInfo | null).	The store now attaches pendingSelection to the pending event and the core types include a pendingSelection field typed as SelectionInfo | null.
✅	Capture pendingSelection before inserting the pending mark (so the snapshot reflects the pre-mutation selection).	Selection snapshot is taken prior to calling insertComment and tests assert the pending event is emitted before the pending mark insertion.
✅	Allow ui.comments.createFromCapture to accept the pending event's SelectionInfo shape (i.e., a CommentAnchorCapture with target) without requiring a cast, and forward the target to comments.create.	The createFromCapture signature was widened to accept CommentAnchorCapture and a unit test verifies passing a SelectionInfo-shaped object works and forwards the target to the underlying create call.
✅	Export the new CommentAnchorCapture type from the public UI surface so consumers can rely on it.	The CommentAnchorCapture type was added and exported from the UI index/public files.

<sub>Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more

Re-trigger cubic</sub>

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!