Skip to content

chore(comments): fix typo #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SkalaNetworks merged 1 commit into from
Jul 22, 2026
Merged

chore(comments): fix typo #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions internal/replicator/replicator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ func (c *Controller) processNextItem() bool {
// - if the VolumeReplication exists
// - check if the PVC has a matching VolumeReplicationClass
// - and if it doesn't, delete the VolumeReplication
// - check if the target of the VolumeReplication is correct
// - and if it doesn't, delete it, and it will be re-created on the next sync
// - check if the class/target of the VolumeReplication is correct
// - and if it isn't, delete it, and it will be re-created on the next sync
// - check if the replicationState of the VolumeReplication is correct
// - and if isn't, live update the VolumeReplication
// - and if it isn't, live update the VolumeReplication
//
// - if the VolumeReplication doesn't exist
// - and if a corresponding VolumeReplicationClass exists, create the VolumeReplication
Expand Down Expand Up @@ -115,9 +115,9 @@ func reconcileVolumeReplication(key string) {

// The VolumeReplication exists, we need to check:
// - if the PVC still has a matching VolumeReplicationClass
// - and if it doesn't, we need to delete the VolumeReplication (we can't live update the class)
// - if the target of the VolumeReplication is correct
// - and if it isn't, we need to delete the VolumeReplication (we can't live update the target)
// - and if it doesn't, we need to delete the VolumeReplication
// - if the class/target of the VolumeReplication is correct
// - and if it isn't, we need to delete the VolumeReplication (we can't live update those fields)
// - if the replicationState of the VolumeReplication is correct
// - and if it isn't, we live update the VR
if volumeReplication != nil {
Expand Down
Loading