Skip to content

test(cli): cover functions deploy unit tests with effect lint (CLI-2592) - #6970

Open
7ttp wants to merge 1 commit into
7ttp/cli-2592-functions-area-coverage-deployfrom
7ttp/cli-2592-functions-area-coverage-deploy-tests
Open

7ttp wants to merge 1 commit into
7ttp/cli-2592-functions-area-coverage-deployfrom
7ttp/cli-2592-functions-area-coverage-deploy-tests

Conversation

@7ttp

@7ttp 7ttp commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

TL;DR

brings the deploy unit tests under the effect lint

whats introduced?

  • deploy.unit.test.ts joins the allow list
  • the tests keep every existing case and run on @effect/vitest with BunServices, building fixtures through FileSystem and Path in scoped temp dirs and encoding JSON through Schema
  • failure assertions read the exit cause instead of catching a rejection, and pin both import walk failures as defects, the FunctionImportNotDirectoryError and the native ENOENT host error
  • a new test pins which entries discoverFunctionSlugs counts as functions, keeping symlinked directories and skipping files, links to files, broken links and directories without an entrypoint

ref

@7ttp 7ttp self-assigned this Oct 2, 2026
@7ttp
7ttp added this pull request to stack #6969 October 2, 2026 21:26
@7ttp
7ttp requested a review from a team as a code owner October 2, 2026 21:26

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews completed and reported no findings. Reading the checked-out changes and implementation revealed no additional actionable issues: the Effect test migration preserves the assertions, scoped cleanup is appropriate, and the new symlink-discovery expectations match the implementation. Tests were not executed because dependencies are unavailable.

Findings

No issues found.

Stats

Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant