Conversation
Contributor
There was a problem hiding this comment.
🤖 AI Review
No production correctness bugs were found. Claude reported four quality/polish issues; all are confirmed, with the missing live-test cancellation signal raised to minor severity. Codex completed its review and reported no findings, and the adjudication pass found no additional issues.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | apps/cli/src/commands/functions/delete/delete.live.test.ts:30 |
test-quality |
claude | The live test does not pass Vitest's abort signal to Effect.runPromise, so test cancellation cannot promptly interrupt its deploy, delete, and cleanup fibers. |
| ⚪ NIT | apps/cli/src/commands/functions/list/list.integration.test.ts:207 |
naming |
claude | Seven assertions assign Cause.pretty output to a variable named json even though the value is human-readable cause text, not JSON. |
| ⚪ NIT | apps/cli/src/commands/functions/list/list.format.ts:12 |
readability |
claude | The invalid-input fallback creates six NaN values and sends them through the normal formatting pipeline merely to reproduce a constant legacy string. |
| ⚪ NIT | apps/cli/src/commands/functions/new/new.integration.test.ts:232 |
test-quality |
claude | Effect.provide wraps withEnvVar, so the test layer is acquired outside the SUPABASE_YES scope, making the ordering fragile if a layer later reads that variable. |
Stats
Claude findings: 4 · Codex findings: 0 · Confirmed: 4 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5 + gpt-5.6-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
7ttp
added this pull request to stack #6695
September 21, 2026 21:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
brings
supabase functionsdelete, list and new under the effect lintwhats introduced?
effect lint applied to
functionsdelete, list and new:.oxlintrc.effect.json, the family root plus the three subcommandsnewyields its two tagged errors directly instead of wrapping them inEffect.faillisttimestamps format throughDateTimewhile invalid millis still renderNaN-NaN-NaN NaN:NaN:NaNlike nativeDate, pinned by a new unit testFileSystem/Pathservices, the env case runs throughwithEnvVar, cause assertions useCause.prettycliEffectfixtureref: