Conversation
Contributor
There was a problem hiding this comment.
🤖 AI Review
The two reviews produced six deduplicated findings. Five are confirmed: --legacy-bundle=false bypasses removal handling, removed surfaces skip the telemetry-state persistence flush, and three naming/comment consistency nits remain. The claimed stale divergence documentation is refuted because that document explicitly identifies itself as a frozen historical ledger.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | apps/cli/src/commands/functions/download/download.handler.ts:19 |
correctness |
claude+codex | An explicitly supplied --legacy-bundle=false is not rejected, contrary to the command contract, and therefore does not emit removed-flag telemetry. |
| 🟡 MINOR | apps/cli/src/command-internal/removed-command.ts:35 |
telemetry |
codex | The new removed-command and removed-flag failure paths bypass the required TelemetryState.flush persistence step. |
| ⚪ NIT | apps/cli/src/commands/functions/download/download.command.ts:28 |
consistency |
claude | The tombstoned --legacy-bundle flag still has the functional description "Use legacy bundling." rather than describing its removal and replacement. |
| ⚪ NIT | apps/cli/src/shared/functions/download.ts:805 |
naming |
claude+codex | suggestLegacyBundle no longer describes its returned suggestion, which now recommends --use-api and redeployment. |
| ⚪ NIT | apps/cli/scripts/build.ts:292 |
documentation |
claude | A build comment still says the musl package receives supabase-go so GoProxy can find it, although this PR removes GoProxy. |
Findings outside the diff
- ⚪ NIT
apps/cli/src/commands/functions/download/download.command.ts:28— The tombstoned--legacy-bundleflag still has the functional description "Use legacy bundling." rather than describing its removal and replacement. - ⚪ NIT
apps/cli/src/shared/functions/download.ts:805—suggestLegacyBundleno longer describes its returned suggestion, which now recommends--use-apiand redeployment. - ⚪ NIT
apps/cli/scripts/build.ts:292— A build comment still says the musl package receivessupabase-gosoGoProxycan find it, although this PR removesGoProxy.
Refuted findings (kept for transparency, not posted as review comments)
apps/cli/docs/go-cli-divergences.md:165(documentation): The divergences document incorrectly presentsdb remote changes --passwordprecedence as live behavior after the command became a tombstone.
Refuted: go-cli-divergences.md:3-9 explicitly labels the entire document a "Frozen historical ledger" retained to answer migration questions and says it is not a current compatibility promise. The cited CLI-1970 history is therefore appropriate in that context.
Stats
Claude findings: 5 · Codex findings: 3 · Confirmed: 5 · Refuted: 1 · Uncertain: 0
Models: claude-opus-5 + gpt-5.6-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Coly010
force-pushed
the
columferry/cli-2432-remove-the-residual-go-cli-delegation-and-delete-appscli-go-remove-delegation
branch
from
September 15, 2026 09:22
8eb3f2a to
368e56c
Compare
Base automatically changed from
columferry/cli-2432-remove-the-residual-go-cli-delegation-and-delete-appscli-go-prep
to
develop
September 16, 2026 12:43
Removes the last delegation paths that spawned the bundled `supabase-go` sidecar binary and deletes the `GoProxy` service that wired them up. Removed: - `db branch create|delete|list|switch` — local database branches (a container-cloning feature distinct from hosted preview branches) are no longer supported. Use `supabase branches --help` for hosted preview branches. - `db remote changes` — use `supabase db diff --linked` instead. - `gen keys` — use `supabase projects api-keys --project-ref <ref>` to read a project's API keys. - `db diff --use-pg-schema` — deprecated since CLI-1960; removed in favor of the default migra engine or `--use-pg-delta`. - `functions download --legacy-bundle` (hidden flag) — retry with `functions download --use-api <slug>`, or redeploy with a current CLI if the Function predates 1.120.0. Each removed path fails with exit code 1 and a suggestion naming its replacement, and is measurable via a new `RemovedSurfaceError` telemetry fingerprint, rather than a bare unknown-command/unknown-flag parse error. Linear: CLI-2432 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Rejects --legacy-bundle=false on functions download the same as an explicit true (presence, not value, like --use-pg-schema); flushes TelemetryState from the tombstone/removed-flag paths, which previously skipped it entirely; and cleans up a stale flag description, a misleading suggestion-builder name, and a comment referencing the removed GoProxy. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Coly010
force-pushed
the
columferry/cli-2432-remove-the-residual-go-cli-delegation-and-delete-appscli-go-remove-delegation
branch
from
September 18, 2026 12:57
368e56c to
d700564
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature removal — breaking change.
What is the current behavior?
The CLI still spawns a bundled
supabase-gosidecar binary for five deprecated paths via aGoProxyservice:db branch create|delete|list|switch,db remote changes,gen keys,db diff --use-pg-schema, and the hiddenfunctions download --legacy-bundleflag.Stacked on #6604 (relocates the Docker image manifest out of the Go tree; no behavior change).
What is the new behavior?
db branch create|delete|list|switch,db remote changes, andgen keysnow fail with exitcode 1 and a message naming a replacement, instead of proxying to Go:
db branch *— local database branches (container-cloning) are removed; seesupabase branches --helpfor hosted preview branches, a different product.db remote changes— usesupabase db diff --linked.gen keys— usesupabase projects api-keys --project-ref <ref>to read a project's API keys.db diff --use-pg-schema(deprecated since CLI-1960) is rejected with guidance to use thedefault migra engine or
--use-pg-delta, instead of delegating to Go'spg-schema-diff.functions download --legacy-bundle(a hidden flag) is tombstoned the same way, pointing at--use-apior a redeploy with a current CLI.GoProxyservice, its layer, and all wiring incli/root.ts/shared/cli/run.tsare deleted.RemovedSurfaceErrortelemetry fingerprint distinguishescommand- and flag-removals, so residual usage can be tracked before these stubs are eventually
deleted outright.
Part of CLI-2432