Skip to content

feat(): implement purge cache issue - #50

Merged
Tr00d merged 2 commits into
masterfrom
feature/purge-cache
Jul 29, 2026
Merged

feat(): implement purge cache issue#50
Tr00d merged 2 commits into
masterfrom
feature/purge-cache

Conversation

@diegofesanto

Copy link
Copy Markdown
Collaborator

What kind of change does this PR introduce?

feature

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Additional context

@diegofesanto
diegofesanto requested a review from Tr00d July 29, 2026 02:00
@diegofesanto

diegofesanto commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

@Tr00d could you check this pr, please?

I will put the FetchParameter on download method tomorrow that was missed

@Tr00d

Tr00d commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@diegofesanto Thanks a lot for contributing again.
I went through the PR and ended up making a few changes (made another PR to be merged in this one, here #52), rather than stacking review comments over here.
Here's my reasoning behind it:

  • The FetchParameter/FetchCache types were modeled on the JS fetchParameters, but over there that's really just the abord signal. In .NET, it's the CancellationToken you already added, so I dropped those types. They were also serialized into the DELETE body, which the server doesn't expect.
  • transformations defaults to purging everything on storage-js, so I changed the default to match (it was purging only transformations by default)
  • I reworked the tests to check what's actually sent to the API: the path, absence of body, the transformations query and that cancellation is passed through.

None of this changes what you built, it's mostly aligning with JS the best we can and strengthening the tests.
Happy to talk though it, I mostly wanted to avoid a round of back-and-forth comments.

Cheers!

@diegofesanto

Copy link
Copy Markdown
Collaborator Author

@Tr00d thanks... I got it.

I merged your PR already...

@Tr00d
Tr00d merged commit 41ee1f8 into master Jul 29, 2026
1 check passed
@Tr00d
Tr00d deleted the feature/purge-cache branch July 29, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants