feat(installer): add allow_insecure_origin setting - #8
Merged
Merged
Conversation
Write OAC_ALLOW_INSECURE_ORIGIN=1 to the installation .env when install.sh (or install.dev.sh) runs with --allow-insecure-origin, and pass it through to Core in compose.yaml. Core already reads the switch (processconfig) to accept a non-loopback plain-HTTP OAC_PUBLIC_URL; the deployment side owned no way to set it after the Compose refactor. Default stays off: without the flag the variable is absent and Core keeps rejecting a non-loopback HTTP origin with its original message. TLS certificate verification is unchanged. - deploy/compose/compose.yaml: pass OAC_ALLOW_INSECURE_ORIGIN to core only. - deploy/install.sh, deploy/install.dev.sh: --allow-insecure-origin flag, usage text, and .env line. - deploy/compose/test_compose.py, deploy/test_install.py: cover the pass-through and the .env key. - docs/configuration.md, docs/getting-started/install-options.md and their Chinese translations. Co-authored-by: multica-agent <github@multica.ai>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Task B of OAC-2 on the post-refactor architecture. Upstream PR MiniMax-AI#402 replaced the Python
deploy/install/installer withdeploy/compose/+deploy/install.sh+ a Gooac, so the earlier installer PR (#2) was obsolete. Core already consumes the switch (Task A, merged as PR #7), but the deployment side had no way to set it.This PR adds
--allow-insecure-origintoinstall.sh/install.dev.sh, writesOAC_ALLOW_INSECURE_ORIGIN=1to the installation.env, and passes that variable through to the Core service incompose.yaml. Default stays off: without the flag the variable is absent, so Core keeps rejecting a non-loopback HTTP origin with its original message. TLS certificate verification is unchanged.Baseline:
origin/main @ 8551deb4.Changes
deploy/compose/compose.yaml: passOAC_ALLOW_INSECURE_ORIGINto thecoreservice only (${OAC_ALLOW_INSECURE_ORIGIN:-}); thewebservice is unchanged (Web reads the Core snapshot, not the env).deploy/install.sh:--allow-insecure-originflag, usage text, and the conditional.envline.deploy/install.dev.sh: the same flag and.envline for a local checkout.deploy/compose/test_compose.py:OAC_ALLOW_INSECURE_ORIGINdefaults to empty oncore, and a new test asserts it passes through tocoreonly.deploy/test_install.py: a new test asserts the.envkey is written only with the flag, plus the help-text assertion.docs/configuration.mdanddocs/getting-started/install-options.md(+ Chinese translations,source_hashupdated): document the setting, the flag, and the plaintext risk.Verification
Run on the branch (
feat/installer-allow-insecure-origin@92b7566f, baseorigin/main @ 8551deb4):make check-names→ OK (15 tests;OpenAgentCore name guard passed.)make check-docs→ OK (6 tests)make check-ci→ OK (46 tests)make check-website→ OK (build + 22 tests, including the Chinese-translation freshness check)make check-distribution→ OK (exit 0)/usr/bin/opensslis OpenSSL 1.0.2k, whiledeploy/node/test_node_proxy.pycallsopenssl … -addext; an earlierdeploy/nodetest resetsPATHtonode_install.SAFE_PATH, which drops the directory providing OpenSSL 3.6.3, so thedeploy/nodesuite fails insetUpClasson the raw host. With the modern OpenSSL directory added toSAFE_PATH(the workaround the OAC-2 test verifier documented) the full target passes. CI uses a newer system OpenSSL and is unaffected. This change touches nodeploy/nodecode.python3 deploy/test_install.py→ OK (4 tests),deploy/composesuite → OK (5 tests)python3 scripts/ci_plan.py plan --base origin/main --head HEAD→hygiene,distribution,compose,websiteAcceptance (Task B)
--allow-insecure-originwrites.envandcheck-configreads it; without it, a non-loopbackhttp://fails before the installation can be managed. Demonstrated with the merged Core binary (go build ./services/core/cmd/server):The
.env→ Compose → Core hop is covered bytest_compose.py(pass-through tocoreonly) andtest_install.py(the.envkey is written only with the flag).Merge order
Task A (Core, OAC-3) is already merged (PR #7). This is task B; tasks C (OAC-6, Web console) and D (OAC-4/OAC-8, node link) follow the confirmed A → B → C → D order. This PR can be reviewed and merged now; C and D rebase on it.