Repository navigation
Conversation
Interpolating the spectra onto the channel grid lost or multiplied the flux of lines narrower than the channel sampling.
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Interpolating the spectra onto the channel wavelengths drops or multiplies lines narrower than the channel sampling.
Evidence
test_temperature_response_line, a 0.02 Å unit-integral line gives 50.5× the response at the line when it sits on a channel wavelength, and 0 when it sits between two.After: both give the response at the line. All response tests pass.
aia_get_response(/temperature,/dn)for the seven AIA EUV channels (aiapy'sChannelfrom refactor channel on top of abstract channel class LM-SAL/aiapy#419, SolarSoft V9 emissivity), the worst relative difference is 1.1e-4 before and 3.7e-5 after. The remainder comes from SSW's hc = 12398 eV Å.Merge Danger
Door: two-way
Blast Radius: values
Every
temperature_responseresult changes: slightly for smooth spectra, and a lot for line spectra sampled more finely than the channel.