refactor(isthmus): remove dead WindowRelFunctionConverter and de-duplicate call converters#1014
Open
nielspardon wants to merge 1 commit into
Open
refactor(isthmus): remove dead WindowRelFunctionConverter and de-duplicate call converters#1014nielspardon wants to merge 1 commit into
nielspardon wants to merge 1 commit into
Conversation
…icate call converters WindowRelFunctionConverter was never instantiated or wired into any ConverterProvider and duplicated WindowFunctionConverter; remove it. The WindowRelFunctionInvocation capability it targeted is produced only in core and the Spark integration, both untouched. Have ConverterProvider.getCallConverters() build on CallConverters.defaults() instead of re-listing the identical converters. The order, instances, and mutability of the returned list are unchanged, so this is behavior-preserving. Update SimpleExtensionToSqlOperator javadoc to reflect that window functions are supported (the class already handles them). No behavior change; verified with the isthmus test suite, PMD, spotless, and javadoc. First, low-risk step of the function-mapping refactor. Part of substrait-io#1012
nielspardon
requested review from
andrew-coleman,
benbellick,
bestbeforetoday,
bvolpato and
vbarua
July 15, 2026 15:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
P0 (debris cleanup) of the Isthmus function-mapping refactor — behavior-preserving, no
functional change:
WindowRelFunctionConverter. It was never instantiated or wired intoany
ConverterProvider, and it duplicatedWindowFunctionConverter. TheConsistentPartitionWindow.WindowRelFunctionInvocationcapability it targeted is producedonly in
:core(proto read / copy-on-write rewrite) and the:sparkintegration (its ownconverter) — both untouched — so no reachable capability is removed.
ConverterProvider.getCallConverters()now buildson
CallConverters.defaults(typeConverter)(previously it re-listed the identical firsteight converters) and then appends
CREATE_SEARCH_CONVand the scalar function converter,as before. Order, instances, and the mutable-
ArrayListreturn type are unchanged, sosubclasses that mutate
super.getCallConverters()(e.g.DynamicConverterProvider) keepworking.
SimpleExtensionToSqlOperator: it already handles window functionsvia
toWindowSqlFunction, but the class and threeExtensionCollectionoverloads still said"scalar and aggregate … window functions are not yet implemented".
Why
First, lowest-risk step of the larger function-mapping redesign. See the plan in #1012 and the
umbrella epic #1013.
Verification
./gradlew :isthmus:test :isthmus:pmdMain :isthmus:spotlessCheck :isthmus:javadoc— all pass.:isthmus,:isthmus-cli,:examples:isthmus-api,:examples:substrait-sparkall compile.CallConverters.defaults()and the
DynamicConverterProvideroverride.Part of #1012 (P0); part of epic #1013.
🤖 Generated with AI