Add Fan Suction sensor (reg 52) and flag reg 45 as disputed - #24
Merged
Conversation
Partial adoption of PR #23. Takes the new reg 52 mapping from the HP installer page cross-check, downgraded CONFIRMED -> NAMED until an observed range verifies the Pa unit. Records the reg 45 doc/decoder conflict in identified.md and the decoder. Holds the reg 45 and reg 50 renames pending physics cross-checks (see PR #23 review). Co-authored-by: johncuthbertuk <github@johncuthbert.co.uk> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UzEvwbJCZWxatMhVohBiyf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for a new sensor (register 52 "Fan Suction") and documents a naming dispute for register 45 that requires further investigation before resolution.
Key Changes
New Sensor: Added register 52 "Fan Suction" with Pa unit based on HP installer page label (PR Update registers based on cross-check with installer page #23, thanks @johncuthbertuk)
Disputed Register: Flagged register 45 with detailed dispute documentation
Held Changes: Documented two changes from PR Update registers based on cross-check with installer page #23 that are intentionally held pending resolution:
Version Bump: Updated to 4.10.0
Implementation Details
The Fan Suction sensor includes cautionary comments about unit verification since:
The register 45 dispute is thoroughly documented with specific test methodology (plot over 2026-02-18 06:30-08:21 DHW window) to enable future resolution in a single commit.
https://claude.ai/code/session_01UzEvwbJCZWxatMhVohBiyf