fix: upgrade Go to 1.25.14 and x/sys for CVEs - #2133
Merged
Merged
Conversation
Addresses the findings Trivy reports against bin/pulsarctl in the sn-platform 4.0.12.3 image. Eight of the nine are Go stdlib (CVE-2026-33818, CVE-2026-39821, CVE-2026-46600, CVE-2026-56853, CVE-2026-56858, CVE-2026-56859, CVE-2026-56860, CVE-2026-56862) and come from the toolchain the binary is built with, so every go-version pin moves from 1.25.12 to 1.25.14 along with the go directive. The fix landed in 1.25.13; staying on the 1.25 line avoids a language version jump. The ninth is CVE-2026-39824, an integer overflow in NewNTUnicodeString, fixed by x/sys 0.39.0 -> 0.44.0. Builds clean. go vet reports one pre-existing finding in pkg/test/pulsar/standalone_test.go that is unrelated to these upgrades.
|
@merlimat:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
Bot
added
the
doc-info-missing
This was referenced Aug 20, 2026
shibd
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the 9 findings Trivy reports against
bin/pulsarctlin thesn-platform:4.0.12.3image. Follows the same pattern as #2119.go-versionpins +godirective)golang.org/x/sys0.39.0 → 0.44.0Eight of the nine are Go stdlib (CVE-2026-33818, CVE-2026-39821, CVE-2026-46600,
CVE-2026-56853, CVE-2026-56858, CVE-2026-56859, CVE-2026-56860, CVE-2026-56862)
and come from the toolchain the binary is built with rather than any module, so
the fix is the version pins. It landed in 1.25.13; staying on the 1.25 line
avoids a language-version jump.
The ninth, CVE-2026-39824, is an integer overflow in
NewNTUnicodeString, fixedby x/sys 0.44.0.
The
go.moddiff is just those two lines — x/sys 0.44.0 satisfies the modulegraph, so nothing else was dragged forward.
Targeting
Opened against
mastersince release branches here are cut per platform release(
branch-4.0.12.3is what produced the scanned binary), so this flows into thenext cut. Happy to also patch a release branch directly if a 4.0.12.x respin
needs it sooner.
Verification
go build ./...clean.go vet ./...reports one pre-existing finding inpkg/test/pulsar/standalone_test.go("using resp before checking for errors")that is unrelated to these upgrades and left alone.
Related
Companion PRs covering the rest of the image:
pulsar-detector,pulsarctl-kube,bookie-rackinfo