fix(webstreams): update buffer handling to support Uint8Array in finish - #171
Merged
Conversation
…ebStream functions
…nd adjusting finish call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, after digging into this a bit more, I found a potential DoS issue caused by preserving behavior that was actually based on incorrect API usage. We used to protect against that, but now we fully rely on
ReadableStreamimplementations following the spec and not mutating their own buffers. Also, since Web Streams naturally emitUint8Arraychunks, we can optimize this by avoiding copying the data into a newBuffer.