Skip to content

fix(a11y): use h1 for the product title on product detail pages #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PaulBratslavsky wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(a11y): use h1 for the product title on product detail pages #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion next/components/products/single-product.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const SingleProduct = ({
</div>
</div>
<div>
<h2 className="text-2xl font-semibold mb-4">{product.name}</h2>
<h1 className="text-2xl font-semibold mb-4">{product.name}</h1>
<p className=" mb-6 bg-white text-xs px-4 py-1 rounded-full text-black w-fit">
{locale === 'fr' ? '€' : '$'}
{formatNumber(product.price, locale)}
Expand Down
2 changes: 1 addition & 1 deletion tanstack/src/components/products/single-product.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export const SingleProduct = ({
</div>
</div>
<div>
<h2 className="text-2xl font-semibold mb-4">{product.name}</h2>
<h1 className="text-2xl font-semibold mb-4">{product.name}</h1>
<p className=" mb-6 bg-white text-xs px-4 py-1 rounded-full text-black w-fit">
{locale === 'fr' ? '€' : '$'}
{formatNumber(product.price, locale)}
Expand Down