test-audit: log 2026-08-10 run (no auto-fixes, 8 flagged for review) - #787
Draft
stphung wants to merge 1 commit into
Draft
test-audit: log 2026-08-10 run (no auto-fixes, 8 flagged for review)#787stphung wants to merge 1 commit into
stphung wants to merge 1 commit into
Conversation
All 3 audit agents found the suite free of unseeded RNG, flaky timing, and filesystem issues. No findings fell into the skill's safe-auto-fix categories this cycle (those were already fixed in PR #783); every finding requires human judgment (test consolidation, or changing what an assertion checks) and is flagged for review, including two recurring HIGH-severity masked-assertion tests in the fishing suite. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfGkVNYuAAKjwJkHtGocxM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ran the
test-auditskill (3 parallel Explore agents covering all test scopes: core/combat, systems, items/achievements/misc). All three came back clean on unseeded RNG, flaky timing assertions, and shared filesystem paths.No findings this cycle fell into the skill's safe-auto-fix categories (timestamp buffers, loop-count reduction, RNG seeding, margin widening) — those were already addressed in #783. Every finding this run requires human judgment (test consolidation or changing what an assertion checks), so nothing was auto-fixed. This PR only logs the run to
meta-audit's history per the skill's own tracking convention.Notable findings (flagged, not auto-fixed):
tests/fishing_tests/behavior_lock_fishing_dungeon_test.rs(test_fishing_storm_leviathan_flag_set_on_catch,test_fishing_leviathan_encounter_tracking) fall back to a tautological assertion if their rare-event loop never fires, so they can pass without exercising the named behavior.tests/stormglass_tests/stormglass_test.rsand acrosstests/game_tick_tests/(no sharedhelpers.rs, and copies of the "strong character" fixture disagree on the Constitution stat).Full detail is in the logged JSON entry.
Test plan
scripts/audit-eval-log.sh test-audit— logged successfullyscripts/audit-eval-check.sh test-audit—SKIP: 3/5, meta-audit threshold not reachedGenerated by Claude Code