Speed up Definition of Done and prepare 1.0.51 - #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
--continue; lint and JUnit gates parse that run's fresh reports.cleanopt-in via-Clean, record every gate'sdurationSec, and record whether the build was clean in the receipt.package-lock.jsonand use the local binaries in both PowerShell and CI.versionName 1.0.51/versionCode 51so/cut-releasecan resume from mergedmain.Measured result
41a1e4d)pre-pr-sweep -SkipConnected -SkipInspectCode-Clean -SkipConnected -SkipInspectCode81eccc7)-Clean -SkipInspectCode, Pixel 8 attachedThe broad full-sweep receipt attributes the 412.0s instead of hiding it: text/static 27.0s, clean merged build 17.3s, onboarding UI loops 182.6s, and connected tests 183.4s. The remaining runtime is real device coverage, not repeated JVM/lint builds.
Regression proof
--continueran both.81eccc77adf47dd001a5994c4b14d09d69f3b0e5, withcleanBuild=true,connected=true, andonboardingLoop=passed. Narrow follow-ups updatedsetup-pythonand restored the signing guide tomain; the final release-metadata change then passed a clean rebuild, 647 JVM tests, and a final-head receipt at77100e5. Those focused edits do not invalidate the earlier app/device evidence.Release preparation
versionCode = 51,versionName = "1.0.51".aapt dump badgingreportsversionCode='51' versionName='1.0.51'.gradlew cleanfollowed by the sweep completed in 34.4s with 647/647 JVM tests green.Final coverage
Android Studio Inspect Code was unavailable in this unattended run and is explicitly recorded as skipped; the owner still runs it before merge.
Fixes #174
Note
Medium Risk
Touches CI/sweep orchestration, Gradle caching/configuration-cache settings, and release versioning; behavioral app changes are minimal but a mis-tuned sweep or cache could mask stale build artifacts without
-Clean.Overview
Speeds up the Definition of Done by reordering
pre-pr-sweep.ps1so cheap text/static gates run before Gradle, merging debug/release assembly, Android Lint, and JVM tests into one cached parallel Gradle invocation (with optional-Clean), and enrichingbuild/sweep-receipt.jsonwith per-gate durations and whether a clean build ran.Pins Tier-3 Node tools (
markdownlint-cli2,markdown-link-check,cspell) viapackage-lock.jsonandnpm ciin CI and locally (rootnode_modules/gitignored); CI bumpssetup-pythonto v7 and dropsnpx --yesin favor of local binaries. Gradle enables configuration cache, build cache, and parallel execution ingradle.properties.Narrows default emulator E2E guidance from a mandatory four-AVD sweep to Pixel 8 by default, with Pixel 10 Pro Fold and Pixel 8 API 34 only for posture/preview or FGS/WorkManager/release risks—updated across harness skills and OEM/testing docs.
Release prep: bumps to
versionCode51 /versionName1.0.51.Reviewed by Cursor Bugbot for commit 77100e5. Bugbot is set up for automated code reviews on this repo. Configure here.