fix: mark Storybook generated View import as type-only#895
Merged
dannyhw merged 2 commits intoJun 2, 2026
Conversation
🦋 Changeset detectedLatest commit: ffaf8b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dannyhw
approved these changes
Jun 2, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Generated
storybook.requires.tsimportsViewas a runtime binding even though it is only used as a TypeScript type. This causes TypeScript errors in projects usingverbatimModuleSyntax: true.What I did
Marked the generated
Viewimport as type-only:Updated the generator snapshot tests to match the new output.
How to test
Run:
pnpm --filter @storybook/tests testI also verified the React Native package type check:
Does this need a new example in examples/expo-example?
Does this need an update to the documentation?