Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/add-storybook-telemetry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@storybook/react-native': patch
---

Add Storybook telemetry when on-device Storybook is enabled, with opt-out via `STORYBOOK_DISABLE_TELEMETRY`. Telemetry runs from the unified `withStorybook` wrapper and the Re.Pack plugin.
4 changes: 1 addition & 3 deletions packages/react-native/src/metro/withStorybook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,7 @@ export function withStorybook(
const disableTelemetry = optionalEnvToBoolean(process.env.STORYBOOK_DISABLE_TELEMETRY);

if (!disableTelemetry && enabled) {
const event = process.env.NODE_ENV === 'production' ? 'build' : 'dev';

telemetry(event, {}).catch((e) => {});
telemetry('dev', {}).catch((e) => {});
Comment thread
ndelangen marked this conversation as resolved.
}

if (!enabled) {
Expand Down
4 changes: 4 additions & 0 deletions packages/react-native/src/repack/withStorybook.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ jest.mock('../../scripts/generate', () => ({
generate: jest.fn(),
}));

jest.mock('storybook/internal/telemetry', () => ({
telemetry: jest.fn(() => Promise.resolve()),
}));

const { generate } = require('../../scripts/generate') as typeof import('../../scripts/generate');

function createCompilerMock() {
Expand Down
9 changes: 8 additions & 1 deletion packages/react-native/src/repack/withStorybook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import * as path from 'path';
import { generate } from '../../scripts/generate';
import { createChannelServer } from '../metro/channelServer';
import type { WebsocketsOptions } from '../types';
import { loadWebsocketEnvOverrides } from '../env-tools';
import { envVariableToBoolean, loadWebsocketEnvOverrides } from '../env-tools';
import { telemetry } from 'storybook/internal/telemetry';

/**
* Minimal compiler types for webpack/rspack compatibility.
Expand Down Expand Up @@ -138,6 +139,12 @@ export class StorybookPlugin {
return;
}

const disableTelemetry = envVariableToBoolean(process.env.STORYBOOK_DISABLE_TELEMETRY, false);

if (!disableTelemetry && enabled) {
telemetry('dev', {}).catch((e) => {});
Comment thread
ndelangen marked this conversation as resolved.
}

this.applyEnabled(compiler, {
configPath,
websockets,
Expand Down
4 changes: 4 additions & 0 deletions packages/react-native/src/withStorybook.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ jest.mock('storybook/internal/telemetry', () => ({
telemetry: jest.fn(() => Promise.resolve()),
}));

jest.mock('storybook/internal/telemetry', () => ({
telemetry: jest.fn(() => Promise.resolve()),
}));

describe('withStorybook (unified)', () => {
const metroConfig = { resolver: {}, transformer: {} } as MetroConfig;

Expand Down
7 changes: 7 additions & 0 deletions packages/react-native/src/withStorybook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,16 @@ import type { WithStorybookOptions } from './metro/utils';
import { generate } from '../scripts/generate';
import { createChannelServer } from './metro/channelServer';
import { envVariableToBoolean, loadWebsocketEnvOverrides } from './env-tools';
import { telemetry } from 'storybook/internal/telemetry';

function isMetroConfig(config: unknown): config is MetroConfig {
return config != null && typeof config === 'object' && 'transformer' in config;
}

export function withStorybook<T extends unknown>(config: T, options: WithStorybookOptions = {}): T {
const enabled = envVariableToBoolean(process.env.STORYBOOK_ENABLED, options.enabled ?? false);
const disableTelemetry = envVariableToBoolean(process.env.STORYBOOK_DISABLE_TELEMETRY, false);

if (!enabled) {
return config;
}
Expand All @@ -24,6 +27,10 @@ export function withStorybook<T extends unknown>(config: T, options: WithStorybo
);
const settings = { ...options };

if (!disableTelemetry && enabled) {
telemetry('dev', {}).catch((e) => {});
Comment thread
ndelangen marked this conversation as resolved.
}

if (!server) {
settings.experimental_mcp = false;
}
Expand Down